Consolidate /projects/public into /projects #33033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcavoy
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deletes the HAML view and JS entry-point for
/projects/public-- it was duplicated code from/projects, so this is the first step toward condensing the logic for these two routes.Background
I'm adding a new tab to
/projects(called "My Libraries" -- see STAR-748), and noticed that a lot of the code between/projectsand/projects/publicis unnecessarily duplicated (it looks like an artifact from our Angular days). So before I add a new tab, I'm doing some cleanup!Testing story
There should be no user-visible change, so I manually tested that /projects and /projects/public work as expected for various relevant users (signed out + in and project_validator admin).
Reviewer Checklist: