Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Applab Datasets] Fix experiment check #33058

Merged
merged 1 commit into from
Feb 10, 2020
Merged

[Applab Datasets] Fix experiment check #33058

merged 1 commit into from
Feb 10, 2020

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented Feb 10, 2020

Small follow up bug fix to #32973.
datasetInfo.published || experiments.SHOW_UNPUBLISHED_FIREBASE_TABLES is always truthy since experiments.SHOW_UNPUBLISHED_FIREBASE_TABLES is a string. I need to instead be checking for experiments.isEnabled(experiments.SHOW_UNPUBLISHED_FIREBASE_TABLES)

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

jmkulwik
jmkulwik approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@jmkulwik jmkulwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix

@ajpal ajpal merged commit 1b358b9 into staging Feb 10, 2020
@ajpal ajpal deleted the feb10-experiment-bug branch February 10, 2020 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmkulwik jmkulwik jmkulwik approved these changes

Assignees
No one assigned
Labels
star-labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajpal @jmkulwik