Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standards report part4 #33076

Merged
merged 6 commits into from
Feb 11, 2020
Merged

Standards report part4 #33076

merged 6 commits into from
Feb 11, 2020

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Feb 11, 2020

  1. If you X out of the create report dialog instead of clicking the button to create the report you will not have the report created for you.
  2. Show a spinner until all the information for the print report is loaded and ready to be displayed
  3. When you click the name of an unplugged lesson in the unplugged lesson dialog it will now open in a new page.

Links

Testing story

  • Updated tests for create report dialog

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link

@clareconstantine clareconstantine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks for the super clear description of what this PR accomplishes - that made it very easy to figure out what was happening in the code :)

@dmcavoy dmcavoy merged commit 9f6c70d into staging Feb 11, 2020
@dmcavoy dmcavoy deleted the standards-report-part4 branch February 11, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants