Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove excess 'erb()' calls #33085

Merged
merged 2 commits into from Feb 13, 2020
Merged

remove excess 'erb()' calls #33085

merged 2 commits into from Feb 13, 2020

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Feb 11, 2020

A couple of our pegasus rendering options are processing results as erb in addition to their actual result; this is unnecessary.

Testing Story

I checked all affected filetypes to see if any of them contained ERB syntax, and none do:

$ find . -name "*.fetch" | xargs -d '\n' grep "<%"
$ find . -name "*.redirect" | xargs -d '\n' grep "<%"
$ find . -name "*.moved" | xargs -d '\n' grep "<%"
$ find . -name "*.301" | xargs -d '\n' grep "<%"
$ find . -name "*.found" | xargs -d '\n' grep "<%"
$ find . -name "*.302" | xargs -d '\n' grep "<%"

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms marked this pull request as ready for review February 11, 2020 21:35
@Hamms Hamms merged commit 13a14b7 into staging Feb 13, 2020
@Hamms Hamms deleted the remove-excess-erbs branch February 13, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants