New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require secrets for Rack-based integration tests #33096

Merged

wjordan merged 2 commits into staging from unit_test_config_ru_fix

Feb 13, 2020

Contributor

wjordan commented Feb 12, 2020 •

edited

Fixes an issue running test_hourofcode_helpers by itself, by ensuring that secrets aren't required when loading from a unit-test environment.

Also fixes the more general underlying issue by not loading SecretsManager client when no secrets are actually required within the environment.

wjordan added 2 commits

February 11, 2020 17:25


          Don't require secrets for Rack-based integration tests

b50b110

Fix issue running test_hourofcode_helpers.


          Don't load SecretsManager when no secrets are required

0080a75

wjordan merged commit 067f3f5 into staging

wjordan deleted the unit_test_config_ru_fix branch

February 13, 2020 00:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment