Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove failing Standards Report tests #33098

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Remove failing Standards Report tests #33098

merged 1 commit into from
Feb 12, 2020

Conversation

clareconstantine
Copy link

@clareconstantine clareconstantine commented Feb 12, 2020 •
edited

For some reason the @skip wasn't happening and these tests are preventing a DTP. Removing for now - the feature they are testing is behind a flag and not yet live.

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@clareconstantine clareconstantine merged commit 70c5787 into staging Feb 12, 2020
@clareconstantine clareconstantine deleted the remove-failing-standards-tests branch February 12, 2020 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcavoy dmcavoy dmcavoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clareconstantine @dmcavoy