Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mostly-no-op change with a small bug fix.
It seems like the intention was to have
initializeCodeMirrorForJson
be a general purpose function, but at the same time, its code was really intertwined with the specific blocks edit page use case. I decided it would be cleaner to have the blocks edit page own all of its own logic, and just callinitializeCodeMirror
directly.Along the way, I found that the onChange callback was not being called, since #27138 changed
initializeCodeMirror
to accept an options object, and the call inintializeCodeMirrorForJson
was not changed. This didn't seem to really cause any issues, since the callback was still called on blur, but this PR fixes that so the preview and generated code live-update as you change the config.Testing story
Reviewer Checklist: