Projects page cleanup #33117
Merged
Projects page cleanup #33117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erin007
reviewed
Feb 13, 2020
| limitedGallery={projectsData.limitedGallery} | ||
| canShare={projectsData.canShare} | ||
| /> | ||
| {/* TODO: Move components below into <PersonalProjectsTable/>? */} |
There was a problem hiding this comment.
Those Dialogs are only relevant from the Personal Project Table, so sounds good to me!
There was a problem hiding this comment.
lol i almost forgot about this! i'll make a follow-up PR to scooch these over 🎉
Erin007
approved these changes
Feb 13, 2020
clareconstantine
approved these changes
Feb 17, 2020
This was referenced Feb 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pure refactor, so there should be no user-visible changes here.
Both
projects/index.html.hamlandprojects/index.jshad a lot of artifacts from our AngularJS days, so I'm cleaning that up here to simplify the code (end goal is to add a "My Libraries" tab to the projects/ page).Follow-up work:
<GallerySwitcher/>to<ProjectsGallery/>now that this component renders both the gallery tabs and the content -- Rename <GallerySwitcher/> to <ProjectsGallery/> #33121<PublishDialog/>and<DeleteProjectDialog/>into<PersonalProjectsTable/>Reviewer Checklist: