Add Datasets index page to Levelbuilder #33140
Conversation
| <ul> | ||
| {this.props.datasets.map(dataset => ( | ||
| <li key={dataset}> | ||
| <a href={`/datasets/${dataset}`}>{dataset}</a> |
There was a problem hiding this comment.
For accessibility, should this include a title attribute? i.e. title="{dataset} dataset" --- display as ---> "Dogs dataset"
There was a problem hiding this comment.
(also, is levelbuilder within our accessibility goals?)
There was a problem hiding this comment.
I don't think that would make this more accessible (header on the page is Datasets and the links are /datasets/{name} so I think it is already contextually clear that the list contains the names of datasets).
| @@ -5,8 +5,13 @@ class DatasetsController < ApplicationController | |||
| before_action :initialize_firebase | |||
| authorize_resource class: false | |||
|
|
|||
| LIVE_DATASETS = ['Daily Weather', 'Top 200 USA', 'Top 200 Worldwide', 'Viral 50 USA', 'Viral 50 Worldwide'] | |||
There was a problem hiding this comment.
Is there a way to make this localized?
There was a problem hiding this comment.
What do you mean localized? These are the names of the live tables, which is not translated/translatable.
There was a problem hiding this comment.
Not blocking: Is translating these titles something we'd ever need to worry about? Or if we wanted to internationalize this feature would we instead import data tables with different languages?
Part 1
Fetches the list of tables according to
cdo-v3-shared/v3/channels/shared/counters/tablesand displays them as a list.Links
Testing story
Reviewer Checklist: