Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the small changes for Standards View & Report #33165

Merged
merged 3 commits into from
Feb 18, 2020
Merged

Implement the small changes for Standards View & Report #33165

merged 3 commits into from
Feb 18, 2020

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Feb 17, 2020 •
edited

Updated a bunch of the small changes that were given as feedback in this doc.

StandardsIntroDialog styling

Screen Shot 2020-02-17 at 11 48 15 AM

CreateReport

  • Will show you your last teacher comment if you have entered one since the last reload of window
  • If you close out of the create report dialog we restart you at the first page next time you come back in
  • Link to teacher dashboard projects page

create-report

Standards Report

  • Date doesn't have time now
  • Maps to is no longer a bullet
  • Other styling updates

Screen Shot 2020-02-17 at 11 50 22 AM

Standards Table

  • Lesson boxes start at the same spot in each row
    Screen Shot 2020-02-17 at 11 50 05 AM

@dmcavoy dmcavoy requested a review from a team as a code owner February 17, 2020 16:50
Erin007
Erin007 approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@Erin007 Erin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling all of these little polish items! Please remove dashboard/db/schema_cache.dump from this PR, otherwise good to go!

Hamms
Hamms reviewed Feb 17, 2020
View reviewed changes
apps/i18n/common/en_us.json Outdated Show resolved Hide resolved
clareconstantine
clareconstantine approved these changes Feb 17, 2020
View reviewed changes
Copy link

@clareconstantine clareconstantine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks for tackling all of these details!

@dmcavoy dmcavoy merged commit e105e32 into staging Feb 18, 2020
@dmcavoy dmcavoy deleted the standards-small-fixes branch February 18, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hamms Hamms Hamms left review comments

@clareconstantine clareconstantine clareconstantine approved these changes

@Erin007 Erin007 Erin007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dmcavoy @clareconstantine @Hamms @Erin007