Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use syncronous stdout to _actually_ stream the output of the sync as it happens #33171

Merged
merged 1 commit into from
Feb 17, 2020
Merged

use syncronous stdout to _actually_ stream the output of the sync as it happens #33171

merged 1 commit into from
Feb 17, 2020

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Feb 17, 2020 •
edited

follow-up to #33142

also removed the "copied locale" output form the hoc sync out; that part of the sync happens so quickly, it's not necessary to get a fine-grained progress report

I recommend reviewing the diff with whitespace changes disabled

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms requested a review from a team as a code owner February 17, 2020 21:26
@Hamms Hamms merged commit c113e92 into staging Feb 17, 2020
@Hamms Hamms deleted the stream-sync-output branch February 17, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bethanyaconnor bethanyaconnor bethanyaconnor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hamms @bethanyaconnor