Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standards import url: remove www #33179

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Standards import url: remove www #33179

merged 1 commit into from
Feb 18, 2020

Conversation

Erin007
Copy link
Contributor

@Erin007 Erin007 commented Feb 18, 2020

Follow up to #33149

I don't know why or how to figure out why, but the link for standards metadata from curriculum builder without www works (e.g. https://curriculum.code.org/metadata/coursea-2019/standards.json), but the link with it does not (e.g. https://www.curriculum.code.org/metadata/coursea-2019/standards.json). I removed www so that I can import standards from curriculum builder.

Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it out locally and it works! I'm not convinced you need curriculum.code.org in the CSP anymore (it worked locally without it) because it's all the same domain but I'm not sure

@Erin007 Erin007 merged commit 50d5bbc into staging Feb 18, 2020
@Erin007 Erin007 deleted the standards-import-link branch February 18, 2020 17:42
@wjordan
Copy link
Contributor

wjordan commented Feb 18, 2020

I don't know why or how to figure out why, but the link for standards metadata from curriculum builder without www works [curriculum.code.org], but the link with it does not [www.curriculum.code.org].

Just answering this question- the www link doesn't work because there is no DNS record for www.curriculum.code.org, only one for curriculum.code.org. This can be verified via the AWS Route53 service which maintains DNS records for the code.org domain (either via API or through the AWS Management Console).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants