Summer Workshop Pre Survey

[molly-moen]

Foorm work building on 33182, which adds some generic functionality as well as new foorm survey for the local summer workshop pre-survey ('day 0' survey)

New generic functionality:

• Building on 33297, adds a new model workshop_survey_foorm_submission. This holds metadata for (ideally) all workshop surveys. Metadata included in the table is:
  • foorm_submission_id
  • user_id
  • pd_workshop_id
  • pd_session_id (optional)
  • day (optional)
• Add api controller WorkshopSurveyFoormSubmissionsController which can be used by Foorm.jsx to write foorm results to submissions and workshop_submissions tables.
• Add new view new_general_foorm which directs to Foorm.jsx
• Update Foorm.jsx to take in some new props:
  • submitApi (required): api path to send submission data to
  • surveyData (optional): data to send over to survey (ex. parameters for survey such as course name)
  • submitParams (optional): data to send along to submitApi to contextualize form submission

Local Summer Workshop functionality:

• Add initial version of local summer workshop pre-survey (based on questions in jotform). This survey is accessible at /pd/workshop_survey/foorm/day/0 (any other day parameter will show a 404 since we don't have a new survey for those days yet).
  • this is aligned with current jotform but will most likely be need updates based on feedback from stakeholders

[islemaster]

Nit: Unless there's eager loading going on, I think .foorm_submission is a query in a loop here.

I think you could modify your search before it runs and achieve a similar effect with one query. Something like (and apologies, not sure I've got this right):

    submissions = Pd::WorkshopSurveyFoormSubmission.where(
      user_id: user_id,
      pd_workshop_id: pd_workshop_id,
      pd_session_id: pd_session_id,
      day: day
    )
    
    if form_name
      submissions = submissions.join(:foorm_submission).where(foorm_submission: {form_name: form_name})
    end

    submissions.exists?

[islemaster]

Also, not sure if things still feel too prototype-y to you, but this business logic is a great candidate for a unit test.

[molly-moen]

fixed! your syntax was very close, only difference is .where(foorm_submissions...)
Will do tests in follow-up PR

[breville]

Love the factoring on this. What an impactful change!