Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add teacher_markdown to i18n pipeline #33285

Merged
merged 1 commit into from Feb 25, 2020
Merged

add teacher_markdown to i18n pipeline #33285

merged 1 commit into from Feb 25, 2020

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Feb 24, 2020

Note this does not enable us to begin using this translated content, it simply adds the strings to our pipeline so we can begin collecting translations in advance.

Links

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms requested a review from a team as a code owner February 24, 2020 22:39
@Hamms Hamms merged commit d578bf3 into staging Feb 25, 2020
@Hamms Hamms deleted the translate-teacher-markdown branch February 25, 2020 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bethanyaconnor bethanyaconnor bethanyaconnor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hamms @bethanyaconnor