Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't translate encrypted levels #33289

Merged
merged 1 commit into from Feb 25, 2020
Merged

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Feb 24, 2020

Currently, there are only nine levels in the intersection of "encrypted levels" and "levels we translate":

We've confirmed that the seven CSD levels and the one hoc-encryption do not actually need to be encrypted, and are updating them to indicate as much. The K5-OnlinePD script as a whole is removed from the i18n sync (#33292). So this change should not actually result in any change to the set of levels that are currently being translated.

Links

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms marked this pull request as ready for review February 24, 2020 23:50
@Hamms Hamms requested a review from a team as a code owner February 24, 2020 23:50
@Hamms Hamms merged commit d4a60a0 into staging Feb 25, 2020
@Hamms Hamms deleted the dont-internationalize-encrypted-levels branch February 25, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants