Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codeorg-markdown config #33320

Merged
merged 1 commit into from Feb 26, 2020
Merged

Fix codeorg-markdown config #33320

merged 1 commit into from Feb 26, 2020

Conversation

bethanyaconnor
Copy link
Contributor

Not totally sure why this fixed the down step for the codeorg-markdown project but it seems to have done so locally. 馃し鈥嶁檧

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@bethanyaconnor bethanyaconnor requested a review from a team as a code owner February 25, 2020 22:27
Copy link
Member

@daynew daynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me as long as its well tested.

As for the reason it's failing, have you tried removing public/ from the path?

%original_path% | Use names of the parent folders in Crowdin project to build a file path in the resulted bundle

https://support.crowdin.com/enterprise/configuration-file/

image

Maybe the problem is public is in the actual markdown parent path and so maybe

/pegasus/sites.v3/code.org/i18n/public/%original_path%/%file_name%.%locale%.md.partial

becomes

/pegasus/sites.v3/code.org/i18n/public/public/international/about.es-ES.md.partial

Maybe public gets put in the path twice?

@bethanyaconnor
Copy link
Contributor Author

I'm not sure. The warnings don't have the double public directory:

Warning: Downloaded translations do not match current project configuration. The following files will be omitted:
3:43
- '/i18n/public/educate/curriculum/csf-transition-guide.ca-ES.md'
3:43
- '/i18n/public/international/about.ca-ES.md.partial'
3:43
- '/pegasus/sites.v3/code.org/i18n/public/educate/curriculum/csf-transition-guide.ca-ES.md.partial'
3:43
- '/pegasus/sites.v3/code.org/i18n/public/international/about.ca-ES.md.partial'

Either way, the ** syntax is consistent with what we use in other project(eg hourofcode) so I'd prefer to stick with that.

@bethanyaconnor bethanyaconnor merged commit 4f82855 into staging Feb 26, 2020
@bethanyaconnor bethanyaconnor deleted the fix-markdown-crowdin branch February 26, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants