[student-libraries] Refactor MoveStudents.jsx into MoveStudents.jsx and SortedTableSelect.jsx #33479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmkulwik
changed the title
…raries-with-classes
epeach
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some prefactoring for https://codedotorg.atlassian.net/browse/STAR-777.
We will be reusing the UI of this modal for the element that will allow teachers to share libraries with students.
Before & After. Only difference is the addition of the "Move Students"
Future work: Create a use this element for the Assign Libraries modal (mockup below)
Links
Testing story
Updated existing tests. Added new tests for SortedTableSelect
Reviewer Checklist: