Standards: teacher_scores query optimizations #33492
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Querying for the progress tab is inefficient, particularly new queries for the standards tab related to TeacherScores. This causes performance problems, particularly for large sections. After issues were discovered in production, I temporarily stopped fetching standards data unless the
standardsReport
flag is on (#33467).In this PR, to improve performance of the problematic queries :
get_level_scores_for_stage_for_student
and then deleted it to move database hits to TeacherScores out of loops so we only hit that table once instead of on every iteration.get_level_scores_for_stage_for_section
so we don't have an additional database hit to re-fetch the stage.I also added a test to ensure that increasing the number of students in a section doesn't increase the number of database hits and updated the TeacherScores model tests accordingly.