Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable exporting functions with duplicate names #33530

Merged
merged 2 commits into from Mar 10, 2020
Merged

Disable exporting functions with duplicate names #33530

merged 2 commits into from Mar 10, 2020

Conversation

maddiedierker
Copy link
Contributor

Disables exporting functions with duplicate names in libraries.

Video

Screenshot:
Screen Shot 2020-03-09 at 4 34 04 PM

Links

Testing story

Added a unit test for this case.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@maddiedierker maddiedierker requested a review from a team as a code owner March 10, 2020 00:04
@maddiedierker maddiedierker merged commit d70556c into staging Mar 10, 2020
@maddiedierker maddiedierker deleted the disable-dup-functions branch March 10, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajpal ajpal ajpal approved these changes

Assignees
No one assigned
Labels
star-labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maddiedierker @ajpal