Adhoc / managed envs vimrc [ci skip] #33578
Conversation
| run_list: [ | ||
| local_mode ? 'recipe[cdo-apps]' : 'role[daemon]' | ||
| ], | ||
| run_list: local_mode ? ['recipe[cdo-apps]', 'recipe[cdo-home-ubuntu]'] : ['role[daemon]'], |
There was a problem hiding this comment.
Ah yeah, this is because the role[daemon] on hosted-chef includes cdo-home-ubuntu, so we need to add it here for local_mode (adhoc) deployments.
We might want to consider adding an include_recipe 'cdo-home-ubuntu' to cdo-apps directly so these are added in all cases to simplify this, but I think this is good for now.
| template "/root/#{file}" do | ||
| source "#{file[1..-1]}.erb" | ||
| mode '0644' | ||
| user 'root' | ||
| group 'root' | ||
| end |
There was a problem hiding this comment.
Not sure it's a concern, but will adding all of these files to root home folder have any risk of unintended consequences, e.g., on startup or when running sudo? I don't think it will be a problem, just thinking out loud and pausing on this for a bit.
At least maybe worth manually trying to enter a sudo su root login shell to make sure it doesn't fail to execute the scripts at all or anything.
There was a problem hiding this comment.
👍 Tested sudo su and there are no problems that I can see.
Sets sensible defaults for vim on adhocs and managed environments daemons instances. (Vim defaults to tab width/indent of 8.)
Testing story
Tested on an adhoc.
Reviewer Checklist: