Create migrations for data comparison step #33677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
molly-moen
approved these changes
Mar 17, 2020
bencodeorg
reviewed
Mar 18, 2020
| class CreateContactRollupsFinal < ActiveRecord::Migration[5.0] | ||
| def change | ||
| create_table :contact_rollups_final do |t| | ||
| t.string :email, null: false, index: {unique: true} |
There was a problem hiding this comment.
I had this question on my migration as well -- if we have a unique index on email, will that cause problems if we add a soft delete option? I think here we'd actually only want to hard delete (in the case of account deletion), but just wondering.
There was a problem hiding this comment.
We likely just need hard delete since we're rebuilding everything in each run. However, if we want to use soft delete, we can change the indexes following this instruction https://github.com/rubysherpas/paranoia#about-indexes.
bencodeorg
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create 2 tables:
contact_rollups_final: The final complete data of all contacts in our system. It has the same content and same structure ascontact_rollups_processedtable from the previous execution of the pipeline.contact_rollups_comparisons: Contains the comparison of the currentcontact_rollups_processedand the existingcontact_rollups_final(which is an older version of contact_rollups_processed).Links