Enabling new sign in flow and style fixes. #33784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daynew
force-pushed
the
fnd-1016-ship-new-sign-up-exp
branch
2 times, most recently
from
b57942c
to
026caa3
Compare
daynew
changed the title
daynew
force-pushed
the
fnd-1016-ship-new-sign-up-exp
branch
3 times, most recently
from
50839b3
to
72f52ad
Compare
|
Mocks look good to me! |
bethanyaconnor
approved these changes
Mar 27, 2020
|
Nit: alignment of the radio button labels is slightly off vertically: Also, if the user submits the form while missing the opt-in field, after the error messages appear on the form, the Yes/No are comparatively farther away from the radio buttons |
We had been experimenting with a new sign up flow and the experiment show a small improvement in sign ups. This change removes the old sign page and the experiment code. * Remove old sign up pages. * Remove old vs new sign up experiment code. * Fix styling on the new sign up pages. * Improve RTL experience on the sign up pages.
daynew
force-pushed
the
fnd-1016-ship-new-sign-up-exp
branch
from
72f52ad
to
768e6e2
Compare
|
I have archived the Optimizely experiment and checked off that box in the reviewer checklist (follow up items) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had been experimenting with a new sign up flow and the experiment
show a small improvement in sign ups. This change removes the old sign
page and the experiment code.
Screenshots
Before
After
Marked up changes
Links
Testing story
Follow up tasks
Reviewer Checklist: