Finalize on TeacherDashboardHeader after A/B test #33830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidate TeacherDashboardHeader and TeacherDashboardHeaderWithButtons. Keep only variant that features buttons, and a 'switch section' button to switch sections
mvkski
requested review from
Erin007,
clareconstantine,
dmcavoy and
davidsbailey
Erin007
reviewed
Mar 26, 2020
| <span style={styles.sectionPrompt}> | ||
| {i18n.assignedToWithColon()}{' '} | ||
| </span> | ||
| {this.props.selectedSectionScript.name} |
There was a problem hiding this comment.
You could combine these strings and pass the script name as a variable like this:
code-dot-org/apps/i18n/common/en_us.json
Line 95 in 615055f
There was a problem hiding this comment.
Will ask you more about this over slack
Erin007
reviewed
Mar 26, 2020
| }} | ||
| icon="gear" | ||
| size="narrow" | ||
| color="gray" |
There was a problem hiding this comment.
Can we use the Button component's specified gray just in case we decide to change that default down the road? Like this:
There was a problem hiding this comment.
I will implement this in a follow up PR! trying to get this merged asap right now, ty for the pointer
Erin007
approved these changes
Mar 26, 2020
Erin007
changed the title
islemaster
reviewed
Mar 26, 2020
| } | ||
|
|
||
| getDropdownOptions(optionMetricName) { | ||
| let self = this; |
There was a problem hiding this comment.
I haven't seen the self = this pattern in a while.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate TeacherDashboardHeader and TeacherDashboardHeaderWithButtons.
Keep only variant that features buttons, and a 'switch section' button to switch sections.
We ran this A/B test for a few weeks. The final results are here. Amanda was able to significantly improve the engagement on 'switching sections', after seeing the result of the first round of A/B tests.
Links
Testing story
Unit tests.
Reviewer Checklist: