Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "rewrite youtube iframes" feature #33856

Merged
merged 1 commit into from Mar 26, 2020
Merged

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Mar 26, 2020

This was originally written to add fallback player support to youtube videos that are embedded in level instructions via iframes.

We want to remove this for a number of reasons:

  1. We no longer support embedding youtube videos in markdown directly
  2. We no longer support iframes in markdown at all
  3. We no longer use this renderer for level instructions (we switched to the clientside renderer)
  4. We want to merge the Dashboard and Pegasus markdown renderers, and removing this will make that process easier

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

This was originally written to add fallback player support to youtube videos that are embedded in level instructions via iframes.

We want to remove this for a number of reasons:

1. We no longer support embedding youtube videos in markdown directly
2. We no longer support iframes in markdown at all
3. We no longer use this renderer for level instructions (we switched to the clientside renderer)
4. We want to merge the Dashboard and Pegasus markdown renderers, and removing this will make that process easier
@Hamms Hamms requested review from wjordan and dmcavoy March 26, 2020 17:46
@Hamms Hamms merged commit 44bace4 into staging Mar 26, 2020
@Hamms Hamms deleted the remove-youtube-rewrite branch March 26, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants