Code Break: Can set visible after for lesson #33869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… page. Add test for feature
dmcavoy
changed the title
dmcavoy
changed the title
davidsbailey
approved these changes
Mar 27, 2020
uponthesun
reviewed
Mar 27, 2020
Comment on lines
53
to
55
| formatted_time = Time.parse(stage.visible_after).strftime("%I:%M %p %A %B %d %Y %Z") | ||
| num_days_away = ((Time.parse(stage.visible_after) - Time.now) / 1.day).ceil.to_s | ||
| flash[:notice] = "The lesson #{stage.name} will be visible after #{formatted_time} (#{num_days_away} Days)" |
There was a problem hiding this comment.
please also test the following scenarios:
- the banner is not visible when
visible_afteris absent - the banner is not visible if the time indicated by
visible_afterhas passed (this may be easier to implement after you've added the code to actually hide the lesson, so ok to do in a later PR) - we should do something reasonable if 2 lessons are hidden. if the current code means that both banners appear, that's great. but if one replaces the other, then we might need to do something different -- anything that will prevent a nasty surprise where a lesson remains hidden when we need it to be visible.
- no banner is visible for students
|
Updated the flash notice to concat together when multiple lessons have visible after set.
Added tests for:
|
davidsbailey
approved these changes
Mar 31, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of PLAT-45
Levelbuilders can set
visible_afteron a stage in the script edit page. If the levelbuilder leaves the value forvisible_afterblank ('') then it will default to the next Wednesday at 8am PST. The value will be saved in the.scriptfile and loaded onto the script edit page the next time the level is edited.In addition when you go to the script overview page as a levelbuilder you will see a flash notice that lets you know when a lesson will be visible after.
Follow up work: Next up is using this value to determine if the stage is hidden.
Links
Testing story
Added tests to script_dsl_test.rb for parsing the DSL and serializing stage.
Reviewer Checklist: