Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ActionView for emails #33870

Merged
merged 4 commits into from Mar 27, 2020
Merged

Use ActionView for emails #33870

merged 4 commits into from Mar 27, 2020

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Mar 26, 2020

I ran lib/scripts/test_poste_deliveries.rb (added in #33720) successfully on production and it did not generate any HoneyBadger errors, so we can confidently switch over to the ActionView implementation of email sending (added in #33399) from TextRender.

The template changes here look more significant than they are; currently, we have an .actionview template for each regular template: https://github.com/code-dot-org/code-dot-org/tree/92ad7c3/pegasus/emails. This change just replaces the regular template with the actionview version, so we have just the one: https://github.com/code-dot-org/code-dot-org/tree/2fc3db9/pegasus/emails

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms requested a review from islemaster March 26, 2020 20:08
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 This is so awesome! Thanks for the thorough test here.

@Hamms Hamms merged commit cb19e2f into staging Mar 27, 2020
@Hamms Hamms deleted the use-ActionView-for-emails branch March 27, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants