Initial Foorm Rollups

[molly-moen]

Calculates and shows rollups for teacher engagement and overall success matrices for CSD/CSP Foorm survey results on /pd/workshop_dashboard/daily_survey_results_foorm/. Rollups will show average response for the specific workshop and for all workshops for the course. Example view:

The questions to be rolled up are stored in rollups_by_course.json. Currently only matrix questions that use numeric keys are supported. This PR also includes a new survey configuration for the day 5 CSD/CSP summer workshop, as that survey contains the questions that we currently roll up.

Future work

• add tests
• add CSF rollup configuration
• add per-facilitator rollups (need facilitator surveys first)

Links

• spec
• jira

Testing story

Tested manually that rollups show up correctly for a workshop with day 5 survey results, and no errors occur with workshops with incomplete/no survey results. The new survey results view page is not linked anywhere so it is low-risk.

Reviewer Checklist:

• Tests provide adequate coverage
• Code is well-commented
• New features are translatable or updates will not break translations
• Relevant documentation has been added or updated
• User impact is well-understood and desirable
• Pull Request is labeled appropriately
• Follow-up work items (including potential tech debt) are tracked and linked

[breville]

I love that this is driven by a configuration!

[hacodeorg]

nice!

[breville]

As discussed, a detailed comment in lib/pd/foorm/survey_results.rb that maps out the call sequencing would be very helpful for future users of this code.

[breville]

Again looking forward to what @hacodeorg thinks!

[hacodeorg]

nice!

[hacodeorg]

It takes me a while to follow the details in the flow. I think it makes sense. However, it's quite difficult to find issues without a clear understanding of the caveats/corner cases in function inputs. I can take a deeper look in your next PR with tests.
Are we planning to make the rollup pipeline generic or it is completely just for Foorm?

[molly-moen]

thanks @hacodeorg! For now the plan is for it to work with Foorm only, since the formats end up being pretty specific it would be hard to make it generic. I am working on the tests in the follow-up PR, let me know if there are other things I can do to make the code clearer.