Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove HTML versions of a bunch of strings that now have markdown versions #33914

Merged
merged 3 commits into from Apr 6, 2020
Merged

remove HTML versions of a bunch of strings that now have markdown versions #33914

merged 3 commits into from Apr 6, 2020

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Mar 30, 2020 •
edited

markdown version added in #33566; HTML versions replaced with markdown in #33567 #33930

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms requested a review from a team as a code owner March 30, 2020 18:45
daynew
daynew approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@daynew daynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compared the keys and it looks like they all have a markdown equivalent.

@Hamms Hamms merged commit 9359e77 into staging Apr 6, 2020
@Hamms Hamms deleted the remove-old-html-strings branch April 6, 2020 18:09
@Hamms Hamms mentioned this pull request Apr 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daynew daynew daynew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hamms @daynew