Fixed droplet tooltips so they no longer cover blocks #33920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpal
reviewed
Mar 30, 2020
| @@ -87,6 +87,13 @@ DropletBlockTooltipManager.prototype.installTooltipsForCurrentCategoryBlocks_ = | |||
| const hoverDivRect = blockHoverDiv.getBoundingClientRect(); | |||
| const toolboxRight = $('.droplet-palette-scroller').width(); | |||
| const offsetX = Math.min(hoverDivRect.width, toolboxRight); | |||
| if (offsetX === 0) { | |||
There was a problem hiding this comment.
Is it possible offsetX could ever be 0 at a time when we would want to render the tooltip?
There was a problem hiding this comment.
I haven't been able to find a case like that so far. Curious if you have any suggestions?
ajpal
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On levels where applab starts in design mode, we hit an issue where the toolbox block tooltip would cover an an entire block. This made it difficult to click the block.
This happened because the block and toolbox locations were calculated while in design mode when the two had not yet been created.
This PR fixes this issue by waiting to calculate the tooltip location until the block and toolbox has been rendered.
Links
Testing story
Reviewer Checklist: