Simplify legacy applab docs sync #33922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applab docs get special treatment in our sync between Dropbox and pegasus -- after discussion with a curriculum writer (GT), curriculum builder experts (Dani and Dave), it appears that these docs are only used in a few legacy places, and are not edited on Dropbox.
As a result, this PR simplifies our sync process to no longer give Applab docs special treatment. Dani also opened a ticket for the team to look into removing these docs entirely.
More to come on cleaning up the Dropbox sync script, but wanted to get this out on it's own for consideration.
Testing story
Code.org/public/applab/docsfolder could be made currently without being synced to pegasus (because of the ignore in the current code I am deleting), I did downloadapplab-docsandapplab-docs-v1folders from dropbox, and diffed them againstCode.org/public/applab/docsandCode.org/public/applab/docs1and saw no difference.