Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Applab Datasets] Add doc link to table description #33933

Merged
merged 3 commits into from Mar 31, 2020
Merged

[Applab Datasets] Add doc link to table description #33933

merged 3 commits into from Mar 31, 2020

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented Mar 30, 2020 •
edited

Add support for linking to additional documentation for each table.
The actual link is specified by the docUrl field in the dataset manifest, which is owned by Levelbuilders:
image

Before:
image

After:
image
image

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@ajpal ajpal changed the title Add doc link [Applab Datasets] Add doc link to table description Mar 30, 2020
@jmkulwik
Copy link
Contributor

Can I just say: I love your example

jmkulwik
jmkulwik approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@jmkulwik jmkulwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ajpal ajpal merged commit 276d45d into staging Mar 31, 2020
@ajpal ajpal deleted the mar30-dataset-docs branch March 31, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmkulwik jmkulwik jmkulwik approved these changes

Assignees
No one assigned
Labels
star-labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajpal @jmkulwik