Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating user model to support parent email notifications #33934

Merged
merged 1 commit into from Mar 31, 2020

Conversation

daynew
Copy link
Member

@daynew daynew commented Mar 30, 2020

We are adding a new feature to enable parents to get notification emails
about their child's progress. This changes make it so when a student
account changes, it will also update the parent's email preferences.

Future work

Still need to test integration with front end. But that will be done in a futre PR.

Links

Testing story

  • Added unit tests.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

dashboard/app/models/user.rb Show resolved Hide resolved
dashboard/test/models/user_test.rb Outdated Show resolved Hide resolved
We are adding a new feature to enable parents to get notification emails
about their child's progress. This changes make it so when a student
account changes, it will also update the parent's email preferences.
@daynew daynew merged commit 16f9b4b into staging Mar 31, 2020
@daynew daynew deleted the parent_email_opt_in branch March 31, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants