Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overwrite contact_rollups_final with contact_rollups_processed #33964

Merged
merged 7 commits into from Apr 6, 2020
Merged

Overwrite contact_rollups_final with contact_rollups_processed #33964

merged 7 commits into from Apr 6, 2020

Conversation

bencodeorg
Copy link
Contributor

Final step in contact rollups process is to overwrite current version of ContactRollupsFinal with ContactRollupsProcessed.

Testing story

Simple unit test here, but could add more.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@bencodeorg bencodeorg requested a review from a team April 1, 2020 16:15
hacodeorg
hacodeorg reviewed Apr 1, 2020
View reviewed changes
lib/cdo/contact_rollups/v2/contact_rollups.rb Outdated Show resolved Hide resolved
dashboard/app/models/contact_rollups_final.rb Outdated Show resolved Hide resolved
dashboard/app/models/contact_rollups_final.rb Outdated Show resolved Hide resolved
dashboard/test/models/contact_rollups_final_test.rb Outdated Show resolved Hide resolved
dashboard/test/models/contact_rollups_final_test.rb Outdated Show resolved Hide resolved
hacodeorg
hacodeorg approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@hacodeorg hacodeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

dashboard/app/models/contact_rollups_final.rb Outdated Show resolved Hide resolved
@bencodeorg bencodeorg merged commit c056b59 into staging Apr 6, 2020
@bencodeorg bencodeorg deleted the contact-rollups-replace-step branch April 6, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islemaster islemaster islemaster left review comments

@molly-moen molly-moen molly-moen left review comments

@hacodeorg hacodeorg hacodeorg approved these changes

Assignees
No one assigned
Labels
contact-rollups
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bencodeorg @islemaster @molly-moen @hacodeorg