Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foorm Pipeline Improvements #33997

Merged
merged 10 commits into from Apr 6, 2020
Merged

Foorm Pipeline Improvements #33997

merged 10 commits into from Apr 6, 2020

Conversation

molly-moen
Copy link
Contributor

This PR contains a couple improvements to the survey pipeline, along with some minor bug fixes:

  • Added unit tests to foorm survey pipeline.
  • Enabled rollups on single-select questions (checkbox, radio, etc.)
  • Minor improvements to CSF intro survey

Links

Testing story

Added unit tests that cover the components of the survey pipeline as well as E2E tests. Verified through unit and manual testing that new rollup types work as expected.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@molly-moen molly-moen requested review from breville and a team April 2, 2020 17:10
Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the testing and all the work you put into building the test data!

@molly-moen molly-moen merged commit feeff58 into staging Apr 6, 2020
@molly-moen molly-moen deleted the molly/rollups-improvements branch April 6, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants