Add parent email confirmation when added to a student account #34015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Email body looks good, did a double read-through to check for typos |
dju90
reviewed
Apr 3, 2020
dashboard/config/locales/en.yml
Outdated
| @@ -250,6 +250,7 @@ en: | |||
| %{name} | |||
| parent_mailer: | |||
| student_associated_subject: 'Login information for Code.org' | |||
| parent_email_added_subject: 'Welcome to Code.org' | |||
There was a problem hiding this comment.
Can you add an exclamation point to the end of the subject? 'Welcome to Code.org!' (same as the teacher email)
…ode-dot-org into parent-email-confirmation
Hamms
approved these changes
Apr 3, 2020
|
|
||
| %p | ||
| Don’t have a computer? We can suggest some options that work great on mobile phones or tablets too! | ||
| %a{href:"https://code.org/athom#apps"}See smartphone options. |
There was a problem hiding this comment.
Suggested change
| %a{href:"https://code.org/athom#apps"}See smartphone options. | |
| %a{href:"https://code.org/athome#apps"}See smartphone options. |
| end | ||
|
|
||
| puts classes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview can be seen at http://localhost-studio.code.org:3000/rails/mailers/parent_mailer/parent_email_added_to_student_account_preview
Links
Testing story
Reviewer Checklist: