Personalized parent letter (story) #34017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erin007
reviewed
Apr 3, 2020
apps/src/lib/ui/ParentLetter.jsx
Outdated
| <img src={secretPicturePath} style={{width: 60, margin: 10}} /> | ||
| </span> | ||
| )} | ||
| </li> | ||
| <li> | ||
| If your student does not remember their picture password, please | ||
| email me and I will provide it |
There was a problem hiding this comment.
We can remove this line from the custom version/when we know the secretPicturePath since they have the info they need right above. Same for word sections.
There was a problem hiding this comment.
Thank you! This is a detail in the spec that I forgot to implement.
Erin007
approved these changes
Apr 3, 2020
|
No need to address, but noting for general future consideration: LP has components strewn about |
islemaster
force-pushed
the
personalized-parent-letter
branch
from
bb45a33
to
5fe2eed
Compare
|
About to merge this, but have another wave of edits from Hadi to do so I'll open another PR very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds personalized variants of the parent letter introduced in #34016 along with associated storybook entries. Implements most of Part 1, Requirement 4 of this spec.
The personalized version also has variants for each login type:
Non-goals
We're intentionally not worrying about making this letter translatable yet. That follow-up work is tracked here.
Testing story
Developed entirely in storybook - nothing here will reach production yet.
Reviewer Checklist: