Parent Letter: generate custom letter for single student #34034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code-dot-org into personalized-parent-letter
…ngle student letter
islemaster
approved these changes
Apr 3, 2020
| @@ -13,7 +15,7 @@ const ENGAGEMENT_URL = | |||
| const LOGIN_TYPE_NAMES = { | |||
| [SectionLoginType.clever]: 'Clever accounts', | |||
| [SectionLoginType.google_classroom]: 'Google Classroom accounts', | |||
| [SectionLoginType.picture]: 'picture passwosrds', | |||
| [SectionLoginType.picture]: 'picture passwords', | |||
There was a problem hiding this comment.
😂 Thank you for catching this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #34021
LP-1366 partial
Parent Letter spec, Req. 6
Generating a Parent Letter for a single student from the manage students table now generates a custom letter for the individual student and opens the print window.