Parent letter: Absolute URLs #34090
Merged
Parent letter: Absolute URLs #34090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
commented
Apr 7, 2020
| * method above to generate absolute URLs. | ||
| * @param {string} origin | ||
| */ | ||
| export function setPegasusOrigin(origin) { |
There was a problem hiding this comment.
Note: I'm using "origin" here after the Location.origin property which is the closest to what we actually mean: A scheme (http/https), a hostname (studio.code.org) and, if needed, a port number.
islemaster
commented
Apr 7, 2020
| <a href={PRIVACY_PLEDGE_URL}>Student Privacy Pledge</a> and their{' '} | ||
| <a href={pegasus('/privacy')}>privacy practices</a> have received{' '} | ||
| <a href={PRIVACY_PLEDGE_URL}>Student Privacy Pledge</a> and their | ||
| privacy practices have received{' '} |
There was a problem hiding this comment.
Whoops! This change, removing one of the privacy links, was supposed to be in the last PR but I forgot to push it. Removed with Amanda's approval because it's basically redundant with other links in the privacy paragraph.
Erin007
approved these changes
Apr 7, 2020
clareconstantine
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we use environment-appropriate absolute URLs for all links in the parent letter. Fixes this issue caught by Erin.
Testing story
Manual testing on local machine.
Reviewer Checklist: