Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raise error if the sync out is run without a sync in #34166

Merged
merged 1 commit into from Apr 13, 2020
Merged

raise error if the sync out is run without a sync in #34166

merged 1 commit into from Apr 13, 2020

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Apr 10, 2020

Otherwise, the sync out will silently skip the restoration process and we'll end up with a bunch of unwanted redacted translations.

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms requested a review from daynew April 10, 2020 19:16
@Hamms Hamms requested a review from a team as a code owner April 10, 2020 19:16
@Hamms Hamms merged commit a066ef5 into staging Apr 13, 2020
@Hamms Hamms deleted the warn-on-no-originals branch April 13, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bethanyaconnor bethanyaconnor bethanyaconnor approved these changes

@daynew daynew Awaiting requested review from daynew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hamms @bethanyaconnor