Homepage: only change action buttons for code break if non-en #34198

Erin007 · 2020-04-13T20:12:24Z

Links

spec
jira

Testing story

Reviewer Checklist:

Tests provide adequate coverage
Code is well-commented
New features are translatable or updates will not break translations
Relevant documentation has been added or updated
User impact is well-understood and desirable
Pull Request is labeled appropriately
Follow-up work items (including potential tech debt) are tracked and linked

breville · 2020-04-13T21:08:40Z

pegasus/src/homepage.rb

@@ -127,7 +127,7 @@ def self.get_actions(request)
    end

    hoc_mode = DCDO.get('hoc_mode', CDO.default_hoc_mode)
-    if code_break_takeover
+    if code_break_takeover && request.language == "en"


I think we'd still have a problem here, and should therefore check for en here instead, so that code_break_takeover only gets set for en users.

only change action buttons for code breakif non-en

5598e92

Erin007 requested a review from breville April 13, 2020 20:12

Erin007 merged commit 4f2308e into staging Apr 13, 2020

Erin007 deleted the non-en-code-break-buttons branch April 13, 2020 20:17

breville reviewed Apr 13, 2020

View reviewed changes

Erin007 mentioned this pull request Apr 13, 2020

Homepage: only set code_break_takeover to true for English #34202

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Homepage: only change action buttons for code break if non-en #34198

Homepage: only change action buttons for code break if non-en #34198

Erin007 commented Apr 13, 2020

breville Apr 13, 2020

Homepage: only change action buttons for code break if non-en #34198

Homepage: only change action buttons for code break if non-en #34198

Conversation

Erin007 commented Apr 13, 2020

Links

Testing story

Reviewer Checklist:

breville Apr 13, 2020

Choose a reason for hiding this comment