Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update category names for CSF 2017 and 2019 #34249

Merged
merged 1 commit into from Apr 15, 2020
Merged

update category names for CSF 2017 and 2019 #34249

merged 1 commit into from Apr 15, 2020

Conversation

davidsbailey
Copy link
Member

I noticed that the category headings are incorrect for CSF versions 2017 and 2019. This PR fixes the problem by updating the corresponding strings in our translation files:

before:
Screen Shot 2020-04-15 at 10 38 35 AM

after:
Screen Shot 2020-04-15 at 10 36 05 AM

Testing story

manually verified as shown in screenshots

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@davidsbailey davidsbailey requested a review from a team as a code owner April 15, 2020 17:40
@davidsbailey davidsbailey requested review from uponthesun and removed request for a team April 15, 2020 17:40
@davidsbailey davidsbailey merged commit c048de3 into staging Apr 15, 2020
@davidsbailey davidsbailey deleted the fix-csf-category-names branch April 15, 2020 21:01
@davidsbailey davidsbailey mentioned this pull request Apr 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uponthesun uponthesun uponthesun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidsbailey @uponthesun