Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSP for Returning Teachers workshop type #34393

Merged
merged 3 commits into from Apr 23, 2020
Merged

Add CSP for Returning Teachers workshop type #34393

merged 3 commits into from Apr 23, 2020

Conversation

islemaster
Copy link
Contributor

Introduces a new workshop type "CS Principles Workshop for Returning Teachers" as the first step in implementing this spec.

Also (temporarily) removes the ability to create a workshop of this type by hiding it from the workshop dashboard dropdown.

Merging this first so that Ben and I can split up the remaining work of making this workshop type function as expected.

Testing story

Checked with a local build that the new constant exists but is omitted from the dropdown.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@bencodeorg
Copy link
Contributor

LGTM -- just did a little double checking and found this reference that I think will evaluate to true for the new workshop type (I think can deal with it later, added to the list of to-dos in the doc we were working in).

@islemaster islemaster merged commit 5d77e00 into staging Apr 23, 2020
@fisher-alice fisher-alice deleted the cspfrt branch July 13, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants