Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataViz] Small Google Chart polish fixes #34422

Merged
merged 3 commits into from Apr 29, 2020
Merged

[DataViz] Small Google Chart polish fixes #34422

merged 3 commits into from Apr 29, 2020

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented Apr 24, 2020

  • Don't show legend at all
  • Add "Count" as axis label for bar charts and histogram
  • Add column name as axis label for scatter plots
  • Overflow auto only for cross tab charts (was causing some weird scrolling behavior for histograms)

Bar
image

Histogram
image

Scatter Plot
image

Cross Tab
image

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@ajpal ajpal merged commit 8b36cba into staging Apr 29, 2020
@ajpal ajpal deleted the apr22-chart-legend branch April 29, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants