Lesson Group: Launch Lesson Groups on Script Overview (Turn off experiment) #34426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcavoy
changed the title
davidsbailey
approved these changes
Apr 27, 2020
| it('returns lesson group if experiment is enabled', () => { | ||
| sinon.stub(experiments, 'isEnabled').returns(true); | ||
| const state = { | ||
| stages: [fakeLesson('Flex Category', 'Lesson Group', 'lesson1', 1)], |
There was a problem hiding this comment.
why are these tests getting removed?
There was a problem hiding this comment.
These are the tests specific to grouping by flex categories and I made corresponding ones for lesson groups in past PRs (which are just below them in this file). These tests will fail with this update if not removed
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
Testing story
Reviewer Checklist: