I18n sync In & Up 04/27 #34435
Merged
I18n sync In & Up 04/27 #34435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bethanyaconnor
approved these changes
Apr 27, 2020
| @@ -918,11 +918,11 @@ | |||
| "lockWhenDone": "Bloquea en cuanto los estudiantes acaben", | |||
| "loggedIn": "Iniciado en: {partner}", | |||
| "loginCardForPrint1": "1.) Ir a [{directLink}]({directLink}) o a la [{joinLink}]({joinLink}) y el tipo en tu código sección letra-6: **{sectionCode}**", | |||
| "loginCardForPrint2": "2.) Elige tu nombre: **{Nombredeestudiante}**", | |||
| "loginCardForPrint2": "2.) Elige tu nombre: **{studentName}**", | |||
There was a problem hiding this comment.
Any idea why these are in this sync?
There was a problem hiding this comment.
oh, woops! I started a sync out of spanish to catch these last week, but got distracted with sprint work and forgot about it. I left the changed files sitting around on the i18n machine, so they got included in the scoop.
Fortunately, them being here won't cause any problems.
Hamms
approved these changes
Apr 27, 2020
| @@ -918,11 +918,11 @@ | |||
| "lockWhenDone": "Bloquea en cuanto los estudiantes acaben", | |||
| "loggedIn": "Iniciado en: {partner}", | |||
| "loginCardForPrint1": "1.) Ir a [{directLink}]({directLink}) o a la [{joinLink}]({joinLink}) y el tipo en tu código sección letra-6: **{sectionCode}**", | |||
| "loginCardForPrint2": "2.) Elige tu nombre: **{Nombredeestudiante}**", | |||
| "loginCardForPrint2": "2.) Elige tu nombre: **{studentName}**", | |||
There was a problem hiding this comment.
oh, woops! I started a sync out of spanish to catch these last week, but got distracted with sprint work and forgot about it. I left the changed files sitting around on the i18n machine, so they got included in the scoop.
Fortunately, them being here won't cause any problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I18n Sync In & Up
This PR contains all changes to internationalization source strings made since the last sync (usually a week).
To Review:
Look through the changes in each of the commits and verify that all changes are expected
We expect content changes to come in on a regular basis; individual strings will get updated, added, and deleted.
We do not usually expect to see "comprehensive" changes - or changes that apply to large numbers of strings or whole categories of strings all at once - unless we have made specific code changes.
Notify the International Partners team about any changes that might appear to manifest as "lost translations"
For example: https://github.com/code-dot-org/code-dot-org/pull/31031/files#diff-aa1910a8cf8f9290ae3baf7e39dbae3eL397-R398
This is a change that added new strings (with both new keys and new content) and simultaneously removed some very similar old ones; we can reasonably infer that the intent here was to swap the new strings out for the old ones. Unfortunately, because the swap also included a content change to the strings the crowdin duplication system won't automatically apply translations to the new strings and so they will need to be manually re-translated.
To Deploy:
Once one or two people have reviewed and approved this change and the tests are passing, ship it!
It's not necessary to wait for everyone on the team to review.