Standards legend improvements #34444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, include in progress status
dmcavoy
approved these changes
Apr 27, 2020
clareconstantine
approved these changes
Apr 27, 2020
yes, we're sacrificing vertical space for consistency in the hopes that it's more maintainable over the long term |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LP-1411
The Standards Report legend didn't include the light green box to indicate that a lesson is "in progress". Now it does, by re-using the same legend from the standards view of the progress tab. I think initially the legend was spec'ed differently on the standards report to save space, but since it can't all fit on one page regardless of the legend size I decided in favor of consistency. I also tightened the layout on both the standards view and the standards report by reducing top margin on the legend.
BEFORE: no in progress status
AFTER: report & progress view share the same legend, including in progress status
