Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confetti to certificate congrats page #34460

Merged
merged 2 commits into from Apr 28, 2020
Merged

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Apr 27, 2020

Follow-up to #34451

Adds some confetti to the certificate congrats page upon personalization!

Peek 2020-04-27 15-49

Open Question

Currently, this only affects the page at studio.code.org/congrats, not the page at code.org/congrats. It's not super clear to me why we still have both of these, but the latter one doesn't currently support React. Rather than trying to add this functionality to that page, I'd suggest the best thing to do would be to just combine these two pages into one. That would of course be more work in the short term than would just adding this feature to both pages, but would of course be better in the long term.

So, are there any objections or concerns to just adding this confetti to one of the congrats pages for now?

Testing story

Tested manually, relying on existing unit tests for long-term testing.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms changed the title Add confetti to certificate Add confetti to certificate congrats page Apr 27, 2020
@Hamms Hamms marked this pull request as ready for review April 28, 2020 00:11
@Hamms Hamms requested a review from Erin007 April 28, 2020 00:11
@Erin007
Copy link
Contributor

Erin007 commented Apr 28, 2020

I don't have any concerns about confetti only being on studio.code.org/congrats. LP-450 tracks the work of consolidating the pegasus and dashboard versions; but, it's been a long uphill battle to prioritize. I would be thrilled to see us tackle this before this year's Hour of Code.

Copy link
Contributor

@Erin007 Erin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This makes the congrats page feel so much more fun!

@Hamms Hamms merged commit 20edb4c into staging Apr 28, 2020
@Hamms Hamms deleted the add-confetti-to-certificate branch April 28, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants