Accessibility Script - Output to chat client #34508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmkulwik
reviewed
Apr 30, 2020
| error_results.each do |error, count| | ||
| puts " #{error} - #{count}" | ||
| ChatClient.message 'wcag-checker', " #{error} - #{count}" |
There was a problem hiding this comment.
[Not blocking] Is it possible to make the error messages more human-readable? i.e. "Clickable Div". Or perhaps just add a link to a doc that makes it easy to find the error?
There was a problem hiding this comment.
This is a good call! There's a lot of rules possible so I'm not sure how to make more human-readable messages, but I think I should be able to programmatically link to WCAG rules. I'm going to attempt in a follow-up once I see if there are other changes I need to make for this to show up nicely in Slack.
jmkulwik
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outputs the results of the accessibility checker to the
wcag-checkerslack channel.Example output from chat_message.log:
Links
Testing story
Reviewer Checklist: