Add parent email to new contact rollups process #34541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencodeorg
changed the title
hacodeorg
reviewed
May 1, 2020
hacodeorg
reviewed
May 1, 2020
hacodeorg
reviewed
May 5, 2020
hacodeorg
approved these changes
May 5, 2020
| @@ -23,25 +23,45 @@ def self.truncate_table | |||
| end | |||
|
|
|||
| def self.extract_email_preferences | |||
| query = extract_from_source_query('email_preferences', ['opt_in'], 'email') | |||
| query = get_extraction_query("#{CDO.dashboard_db_name}.email_preferences", false, ['opt_in'], 'email') | |||
There was a problem hiding this comment.
Non-blocking: what if we change the parameter order by moving source_is_query to the end (closer to source_name) and set its default value to false? This line will be shorter and read more smoothly: get extraction query for <a table> for <several columns>.
Suggested change
| query = get_extraction_query("#{CDO.dashboard_db_name}.email_preferences", false, ['opt_in'], 'email') | |
| query = get_extraction_query("#{CDO.dashboard_db_name}.email_preferences", 'email', ['opt_in']) |
There was a problem hiding this comment.
Fixed, much better!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLC-815
Extracts
parent_emailfrom theuserstable and adds it to the contact rollups pipeline. Note that there are no additional attributes associated with the email being extracted here, just the parent's email address itself.Required a little of restructuring to deal with allowing a subquery to be used. Namely, I've added an optional argument for a
source_namewhen the data isn't coming from a single dashboard table -- @hacodeorg proposed this should follow the structureschema.table.column_name.Testing story
Ran
bin/cron/build_contact_rollups_v2successfully and manually reviewed results in each step of contact rollups process (raw, processed, final). Successful integration test and unit tests for raw and processed steps. Added some new unit testing as well.Reviewer Checklist: