Modify sync-in to also gather function descriptions #34568
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR in the process of translating function descriptions.
Process I'm following:
sync-in
script to gather the function descriptions. I'm changing the structure very slightly so that it's structured like:Note that the key changed from
function_names
tofunction_definitions
. I did this to make the transition a bit easier, plus it makes more sense.2. Before running a sync that contains this PR, upload a file with the existing function names. This will allow duplication to work correctly.
3. Run a sync with this change. The out step will produce
function_defintions.*.yml
and will not updatefunction_names.*.yml
. Check in thefunction_defintions.*.yml
files.4. Modify localized_function_blocks to read from the new translation files. As part of that PR, delete
function_names.*.yml
.This process limits the management of PR/sync timing to step 2. The sync out needs to happened before step 4, but there isn't any complicated PR juggling (i.e. making sure the updated rendering logic the sync go out in the same DTP).
Links
Testing story
Reviewer Checklist: